Wireshark mailing list archives

build warnings


From: Michael Mann <mmann78 () netscape net>
Date: Wed, 13 Jul 2016 21:44:45 -0400


I've done some investigation into the build warnings generated by the Ubuntu and Windows buildbots.  I thought I'd 
highlight some of the "big offenders" so that if anyone has good ideas on how to fix them, it may lead to thinning the 
forest out enough that we can see trees (and the raw number of warnings wouldn't be that alarming).  I don't have 
counts for the number of errors, but trust me, it's probably at least 100 for the issues noted.

Ubuntu:
1. GPOINTER_TO_UINT (and family).

Windows:
1. C files generated by flex/bison.  I know these have always been troublesome for code-analysis tools, so perhaps they 
should be put in a "don't check these" list.
2. qpixelformat.h (Qt library).  VS Code Analysis would prefer to use compiler directives #if instead of "if" when 
comparing what presume to be #define constants (similar changes have been done in the Wireshark source).  Not sure if 
such a fix is worthy of fixing and pushing upstream, but it would clear a lot out.


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: