Wireshark mailing list archives
Re: Has anyone created an XDR to Dissector tool?
From: Jaap Keuter <jaap.keuter () xs4all nl>
Date: Tue, 6 Sep 2016 08:03:16 +0200
Hi, Having zero knowledge of the original code here’s some remarks anyway. @@ -364,7 +370,7 @@ open_input (const char *infile, const char *define) if (infile) - addarg (infile); + addarg (infilename); addarg ((char *) NULL); This must be a general thing then? infile vs. infilename. @@ -1441,6 +1491,7 @@ options_usage (FILE *stream, int status) + f_print (stream, _("-T\t\tgenerate code for a Wireshark dissector\n")); You meant to say _(“-W\t\tgenerate +/* @(#)rpc_wireshark.c 1.0 16/09/01 + * + * Copyright to be determined ... + * + * rpc_wireshark.h, Definitions for the generation of a wireshark + * dissector in rpcgen + */ You probably meant to say rpc_wireshark.c, Functions for the generation of a wireshark dissector in rpcgen +" * GENERATED BY RPCGEN. DO NOT DO SERIOUS EDITS.\n" You might want to add a line stating the Wireshark release (2.0, 2.2, or other) this code is generated for, since the used APIs / includes may depend on it and they may change in the future. Thanks, Jaap
On 06 Sep 2016, at 07:05, Richard Sharpe <realrichardsharpe () gmail com> wrote: On Fri, Sep 2, 2016 at 8:03 AM, Richard Sharpe <realrichardsharpe () gmail com> wrote:For those following along at home, here is a WIP patch against the glibc master version of rpcgen. It builds and runs and generates an incomplete dissector at this stage, but it shows where I think I am headed. I am sure I can do with some feedback even at this early stage, and will likely have something that generates a complete dissector by Monday some time. Of course, whether or not the glibc folks want it is another matter.Made a lot more progress. This thing is doable and in a few more days it will be complete, I think. At the moment it still has some debug artifacts in it but it can generate dissectors for most of the structures generated. However, it does not yet generate code for requests or responses, or the ett or hf array initialization ... -- Regards, Richard Sharpe (何以解憂?唯有杜康。--曹操) <0001-The-WIP-so-far.patch>
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: Has anyone created an XDR to Dissector tool? Jaap Keuter (Sep 01)
- <Possible follow-ups>
- Re: Has anyone created an XDR to Dissector tool? Guy Harris (Sep 01)
- Re: Has anyone created an XDR to Dissector tool? Richard Sharpe (Sep 01)
- Re: Has anyone created an XDR to Dissector tool? Richard Sharpe (Sep 01)
- Re: Has anyone created an XDR to Dissector tool? Richard Sharpe (Sep 02)
- Re: Has anyone created an XDR to Dissector tool? Richard Sharpe (Sep 05)
- Re: Has anyone created an XDR to Dissector tool? Jaap Keuter (Sep 05)
- Re: Has anyone created an XDR to Dissector tool? Richard Sharpe (Sep 06)
- Re: Has anyone created an XDR to Dissector tool? Guy Harris (Sep 06)
- Re: Has anyone created an XDR to Dissector tool? Richard Sharpe (Sep 01)