Re: The build broke on the recent X11 changes

[Jaap Keuter <jaap.keuter () xs4all nl>]

Hi,

Indeed: gcc version 6.3.0 20170406 (Debian 6.3.0-12)

Looking at the code it indeed seems wrong not to have braces there.

Thanks,
Jaap


On 18-04-17 18:49, Alexis La Goutte wrote:
> Hi Jaap,
>
> What release of gcc do you are using ? (i think a recent release...)
>
> On Tue, Apr 18, 2017 at 6:34 PM, Jaap Keuter <jaap.keuter () xs4all nl
> <mailto:jaap.keuter () xs4all nl>> wrote:
>
>     Hi,
>
>     I get this building Wireshark:
>
>     make[6]: Entering directory '/home/jaap/src/wireshark/master/epan/dissectors'
>       CC       packet-x11.lo
>     packet-x11.c: In function ‘dissect_x11_request’:
>     packet-x11.c:3753:13: error: this ‘if’ clause does not guard...
>     [-Werror=misleading-indentation]
>                  if (next_offset - *offsetp > 0)
>                  ^~
>     packet-x11.c:3755:17: note: ...this statement, but the latter is misleadingly
>     indented as if it is guarded by the ‘if’
>                      *offsetp = next_offset;
>                      ^
>     cc1: all warnings being treated as errors
>     Makefile:4388: recipe for target 'packet-x11.lo' failed
>     make[6]: *** [packet-x11.lo] Error 1
>
>     Anyone else?
>
>     Thanks,
>     Jaap

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe