Wireshark mailing list archives

Should I add new commits to address review comments?


From: Richard Sharpe <realrichardsharpe () gmail com>
Date: Tue, 11 Jul 2017 09:10:31 -0700

Hi folks,

Last time I made a change I created a new commit based on review
comments and then squashed the two commits, but that caused issues.

Is it better to simply submit the new commit or do I need to ensure I
keep the original change-id in the commit?

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: