Wireshark mailing list archives

Re: packet-lorawan.c compile error because of stuff added yesterday ...


From: Richard Sharpe <realrichardsharpe () gmail com>
Date: Tue, 13 Jun 2017 16:46:47 -0700

On Tue, Jun 13, 2017 at 4:14 PM, Guy Harris <guy () alum mit edu> wrote:
On Jun 13, 2017, at 1:29 PM, Richard Sharpe <realrichardsharpe () gmail com> wrote:

It's a bit rude to cause build errors just because I don't have gcrypt
1.6.0 or above.

Yes, that's why those #ifs were checked in - without them, you get build errors because the pre-1.6.0 versions of 
libcrypt don't have the gcry_mac_ routines but the code refers to them.  Either we need to require a newer version of 
libgcrypt or we need to have #ifs to avoid using functions not present in the version with which Wireshark is built.

The change in

        https://code.wireshark.org/review/22116

which was just submitted should fix that issue.

Yes. That fixes it. Thanks.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: