Re: Adding pcap-ng pipe support to dumpcap

[Roland Knall <rknall () gmail com>]

Sorry, that was meant to be gerrit. See https://code.wireshark.org/review/

cheers

On Wed, Nov 22, 2017 at 7:19 PM, Roland Knall <rknall () gmail com> wrote:

> Hi
>
> Could you send this to gerri for review? It makes it a lot easier to
> integrate into master
>
> cheers
> Roland
>
> On Wed, Nov 22, 2017 at 7:13 PM, James Ko <jim.list () hotmail com> wrote:
>
> > Attached is my patch to get this working (with caveats).
> >
> > To support this involved reading the the pcapng block header and parsing
> > the just the section header block for endianess.  Then just rewrites the
> > all blocks using the original/input endianess format to the pipe without
> > looking much further at the block contents.
> >
> > It only supports one interface.  I don't fully understand how multiple
> > interfaces are handled  but would probably require parsing the interface
> > description blocks as well to get the linktype and snaplen to put in the
> > interface table.
> >
> > I also did not implement the use_threads option for packet processing.
> >
> > There is #ifdef WIN32 bits but I don't know if any of that is correct as
> > I didn't really touch it and did not even try to compile it.
> >
> > I hope this gets this feature moving along.
> >
> > Regards,
> > James
> >
> >
> > ____________________________________________________________
> > _______________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org?subject=unsubscr
> > ibe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe