Wireshark mailing list archives

Re: Problems building register.c with older glib g_async_queue_timeout_pop()


From: Gisle Vanem <gisle.vanem () gmail com>
Date: Thu, 23 Nov 2017 14:31:34 +0100

Anders Broman wrote:

Problems building register.c with older glib g_async_queue_timeout_pop().

I don't know about this problem.

But another problem is the "\r\n" newlines in a response-file
given to make-dissectors.exe. Should IMHO be:

--- a/epan/dissectors/make-dissectors.c 2017-11-23 12:01:27
+++ b/epan/dissectors/make-dissectors.c 2017-11-23 13:30:13
@@ -57,7 +57,7 @@

     if (!g_file_get_contents(list, &contents, NULL, NULL))
         return;
-    for (arg = strtok(contents, " \n"); arg != NULL; arg = strtok(NULL, " \n")) {
+    for (arg = strtok(contents, " \r\n"); arg != NULL; arg = strtok(NULL, " \r\n")) {
         scan_file(arg, protos, handoffs);
     }
     g_free(contents);

--
--gv
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: