Wireshark mailing list archives
Re: f5ethtrailer: disabled by default
From: Guy Harris <guy () alum mit edu>
Date: Wed, 25 Apr 2018 11:03:39 -0700
On Apr 25, 2018, at 10:37 AM, Jason Cohen <kryojenik2 () gmail com> wrote:
It's not a huge deal, but what would be necessary for the dissector to be enabled by default? The commit message included: Also disable F5ETHTRAILER by default since it doesn't have a discriminating heuristic.
It'd need a discriminating heuristic, which means...
We could probably get the changes needed, but want make sure we understand the requirements.
...that dissect_f5ethtrailer() would have to look at the data it was handed, determine whether it corresponds to an F5 Ethernet trailer and, if not, return FALSE without dissecting anything. It would also have to make sure, before looking at any data, that the data is, in fact, present and not, for example, cut off by a snapshot length in effect when the capture was done. (If the data isn't present, it should return FALSE, as that would mean that some or all of the trailer was cut off by that snapshot length.) ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- f5ethtrailer: disabled by default Jason Cohen (Apr 25)
- Re: f5ethtrailer: disabled by default Guy Harris (Apr 25)