Wireshark mailing list archives

Re: (no subject)


From: Pascal Quantin <pascal.quantin () gmail com>
Date: Wed, 15 Aug 2018 10:28:57 +0200

Hi Ralf,

You patch is under review in Gerrit: https://code.wireshark.org/review/29147
You did not get it with a fresh clone because it has not gone through the
review process test and has not been merged in the repository.

Best regards,
Pascal.


Le mer. 15 août 2018 à 10:24, Nasilowski, Ralf <Ralf.Nasilowski () ise de> a
écrit :

Hi,



I tried to upload my small patch



  Added "wireshark-win32-libs/" and "wireshark-win64-libs/" to ".gitignore"



without success. I proceeded as follows (Windows 7, starting from parent
dir after deleting previous "wireshark" dir:



  $ git clone https://Ralf-Nasilowski () code wireshark org/review/wireshark



  $ cd wireshark



  $ ls .git/hooks



then after noting "commit-msg*" was missing



  $ cd .git/hooks



  $ wget --no-check-certificate https://gerrit.wikimedia.org/r/tools/hooks/commit-msg



  $ cd -



to install the hook.



Then I did my small change in ".gitignore", then



  $ git add .



  $ git status



then after noting no parasitic stuff (such as wireshark-win32-libs/) had
been added



  $ git commit -a



then after noting Change-Id line had been inserted



  $ git review -f



to push. This was apparently successful, however with message "Could not
remove master" or similar.



To verify, I deleted my local "wireshark" dir, and downloaded again with



  $ git clone https://Ralf-Nasilowski () code wireshark org/review/wireshark



However, my small patch was not present in git log, ie the upload failed.



What did I do wrong???





Best regards,



Ralf Nasilowski



*ise Individuelle Software und Elektronik GmbH *



Osterstrasse 15

26122 Oldenburg

Germany



Tel.: +49 441 68006-41

Fax: +49 441 68006-10

E-Mail: Ralf.Nasilowski () ise de <XXXXXXXXXXXX () ise de>

Internet: http://www.ise.de



Commercial register: Amtsgericht Oldenburg, HRB 3701

General manager: Christoph Sahm, Detlef Boss




___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: