Re: pcapng_write_session_header_block

[Guy Harris <guy () alum mit edu>]

On Dec 18, 2018, at 2:43 PM, Jaap Keuter <jaap.keuter () xs4all nl> wrote:

> writecap/pcapio.h has a function pcapng_write_session_header_block() declaration, with matching definition in 
> writecap/pcapio.c
> This name refers to a block that doesn’t exist in the pcap Next Generation Capture File Format(1)
> The format does however contain a block called section header, which is what this function writes.

Section, session, what's one consonant between friends? :-)

> Therefore I propose to rename this function to match the actual block name. 

Yeah, it's just a typo.  Please go ahead and rename the function.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe