Re: What's the process to get a Zookeeper dissector packaged with wireshark?

[Jaap Keuter <jaap.keuter () xs4all nl>]

In addition to this there is some detailed information and pointers to be found in 
https://wiki.wireshark.org/CreatingPatches <https://wiki.wireshark.org/CreatingPatches> and 
https://wiki.wireshark.org/Development/SubmittingPatches <https://wiki.wireshark.org/Development/SubmittingPatches>.

Good luck.

> On 24 Jan 2018, at 10:50, Anders Broman <anders.broman () ericsson com> wrote:
>
> Hi,
> It’s also advisable to start with a small contribution and have that reviewed to get feedback on coding style etc and 
> to get to know the process.
> A small patch stands a much better chance of getting a fast review than a large one.
> Best regards
> Anders Broman
> From: Wireshark-dev [mailto:wireshark-dev-bounces () wireshark org <mailto:wireshark-dev-bounces () wireshark org>] 
> On Behalf Of Dario Lombardo
> Sent: den 24 januari 2018 09:43
> To: Developer support list for Wireshark <wireshark-dev () wireshark org <mailto:wireshark-dev () wireshark org>>
> Subject: Re: [Wireshark-dev] What's the process to get a Zookeeper dissector packaged with wireshark?
>  
> Basically you're right. If it's not included, it's because no one pushed a change for inclusion. Wireshark includes 
> as many protocols as possible and zookeeper would be definitively accepted. 
> Before starting, be sure that something doesn't exist out there: you could start for someone else's code (according 
> to its licence, of course) and not start from scratch.
> When submitting the dissector, please be sure to add sample captures for testing. To add them, just file a bug on 
> bugzilla with your attachments, and add a reference "Bug: XXX" in your commit message that will automatically link 
> the bugzilla page.
> Dario.
>  
> On Wed, Jan 24, 2018 at 9:12 AM, Jeff Widman <jeff () jeffwidman com <mailto:jeff () jeffwidman com>> wrote:
> How do I get a dissector for Zookeeper's protocol included by default in Wireshark?
>  
> I searched but couldn't find anything about what's required to "promote" a dissector to be packaged with wireshark... 
>  
> I assume it's more than just code, that there's some process for deciding whether a protocol is popular enough that a 
> dissector for it could be included in core.
>  
> Zookeeper is an open-source database for reliably storing metadata. Many popular open-source distributed systems rely 
> heavily on it, including Kafka, Hadoop, Druid, etc. 
>  
> Given this popularity, I suspect the only reason it's not bundled into Wireshark is no one has had the time to write 
> it, but wanted to confirm before I start hacking on it.
>
>  
> -- 
>
> Jeff Widman
> jeffwidman.com <http://www.jeffwidman.com/> | 740-WIDMAN-J (943-6265) 
> <>< 
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org <mailto:wireshark-dev () wireshark org>>
> Archives:    https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 
> <https://www.wireshark.org/mailman/options/wireshark-dev>
>              mailto:wireshark-dev-request () wireshark org <mailto:wireshark-dev-request () wireshark 
> org>?subject=unsubscribe
>  
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org <mailto:wireshark-dev () wireshark org>>
> Archives:    https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 
> <https://www.wireshark.org/mailman/options/wireshark-dev>
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe <mailto:wireshark-dev-request () 
> wireshark org?subject=unsubscribe>
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe