Wireshark mailing list archives
Re: How code recognizes that processing of all packets with tap was finished?
From: Jirka Novak <j.novak () netsystem cz>
Date: Fri, 13 Jul 2018 11:47:22 +0200
Hi,
What is not clear to me what should happen when live capture is running? I'm afraid that if I will call "finish" at the end of current live capture (and write footer), later received packet will be delivered to "packet" callbackIf you call "finish" at the *end* of the current live capture, there won't *be* any later received packets. ("End of the current live capture" means "the entire capture is finished", not "we've finished reading the current batch of packets".)
yes, it makes sense. The problem in this case I see with GUI. Imagine use case: 1) User starts live capture 2) User open a dialog where initiate operation which save file with "finish" callback 3) User waits some time (e.g. till progress bar finishes) - application will receive packets, but no "finish" callback was called 4) User closes the dialog and believes that everything is OK, but it is not OK It shows that application/dialog must (some of options): a) notify user that live capture is running and operation can't be used in point 2) b) or notify user that live capture is running and file is not complete in point 3/4) c) dialog must call remove_tap_listener() before close and remove_tap_listener() must call "finish" Probably c) makes sense and can be implemented. Best regards, Jirka Novak ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: How code recognizes that processing of all packets with tap was finished? Jirka Novak (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Guy Harris (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Jirka Novak (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Guy Harris (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Jirka Novak (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Jirka Novak (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Guy Harris (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Peter Wu (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Jirka Novak (Jul 13)
- Re: How code recognizes that processing of all packets with tap was finished? Guy Harris (Jul 20)