Re: How can I run this sort of test before checking in and can it be more useful?

[Guy Harris <guy () alum mit edu>]

On Sep 9, 2018, at 4:17 PM, Richard Sharpe <realrichardsharpe () gmail com> wrote:

> Error: 
> /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/epan/dissectors/packet-ieee80211.c
> uses proto_tree_add_uint with tvb_get_*. Use proto_tree_add_item
> instead
> Args: tree, hf_he_qtp_setup_quiet_period_duration, tvb, offset, 1,
> tvb_get_guint8(tvb, offset)
>
> This is very useful, however, I have two questions:
>
> 1. How do I run this myself before I push stuff to Gerritt?

Build the checkAPI target.

> 2. Can it be more useful and tell me the line number the problem appears on?

Probably - that would involve having tools/checkAPIs.pl keep track of line numbers and put them in the error messages.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe