Wireshark mailing list archives
Re: How to transfer change in dissector from master to current branch?
From: Jirka Novak <j.novak () netsystem cz>
Date: Fri, 21 Sep 2018 08:50:35 +0200
Hi Roland,
Usually only bugfixes and minor features are added to the master branch. In your case, you changed the RTP dissector quite a lot (judging from your patch https://code.wireshark.org/review/#/c/29129/) and most of those seem to be the implementation of new features, not bugfixes. Therefore I do not think merging them to the master would follow the guideline for merging to the master branch.
you are right I changed the code significantly. On the other hand it was just refactoring before I was able to add decoding of a new items in RTP/ED-137 which is minor feature adding :-) OK, I will wait. Thank you for clarification. Best regards, Jirka Novak ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- How to transfer change in dissector from master to current branch? Jirka Novak (Sep 20)
- Re: How to transfer change in dissector from master to current branch? Roland Knall (Sep 20)
- Re: How to transfer change in dissector from master to current branch? Jirka Novak (Sep 20)
- Re: How to transfer change in dissector from master to current branch? Roland Knall (Sep 20)