Wireshark mailing list archives

PFCP Trace information issue in WS 3.0.0 rc1


From: Varun Goyal <varun.goyal () gslab com>
Date: Fri, 22 Feb 2019 19:19:54 +0530

 HI ,

I have seen the code of WS of version 3.0.0 rc1 and found that WS is not
able to decode the IE Trace information correctly.

Observation :
1. Trace info has parameter
    uint32_t Traceid:24,
    uint32_t spare;
*WS does not decoded the spare value* .

static void
  dissect_pfcp_trace_information(tvbuff_t *tvb, packet_info *pinfo _U_,
proto_tree
  *tree, proto_item *item _U_, guint16 length _U_, guint8 message_type _U_,
pfcp_
  session_args_t *args _U_){


/* 8 to 10   Trace ID */
      proto_tree_add_item(tree, hf_pfcp_trace_information_trace_id, tvb,
offset, 3
  , ENC_BIG_ENDIAN);
      offset += 3;   * ========offset+=4 should be there.*
}

2. IP_address

proto_tree_add_item(tree, hf_pfcp_trace_information_ipaddress, tvb, offset,
  length_ipaddress, ENC_NA);
      offset += length_ipaddress; H*ere also , offset += wrong value it
should be fixed with length_ipaddress*sizeof(uint8_t)*

Thanks
Varun Goyal
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: