Re: Version of Qt required?

[Graham Bloice <graham.bloice () trihedral com>]

On Tue, 7 Jul 2020 at 15:30, John Thacker <johnthacker () gmail com> wrote:

> Ah, sorry, that is the result of my recent change. I had checked here
>
> https://wiki.wireshark.org/Development/Support_library_version_tracking
>
> which says that 5.9 and 5.12 had already been required by Wireshark 3.0
> and 3.2 so I went ahead and used it.
The table of Qt versions shows which versions have been used in Wireshark
installers for Windows and macOS. Determining the versions available on
specific Linux distributions is a bit more of an artform but can be gleaned
from the tables further down.


> Does it actually compile and work on 5.6 except for that change?
>
> QT 5.6 is a long term support release and there are some distributions
> stuck on it. I can change my recent commit if we don't want to bump the
> required version.
>
> John
>
> On Tue, Jul 7, 2020, 9:15 AM Martin Mathieson via Wireshark-dev <
> wireshark-dev () wireshark org> wrote:
>
> > In a VM where I build Wireshark, I am getting this error on master:
> >
> > /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp: In member function
> > ‘void FollowStreamDialog::addCodecs(const QMap<QString, QTextCodec*>&)’:
> > /home/martin/wireshark/ui/qt/follow_stream_dialog.cpp:164:47: error:
> > ‘qAsConst’ was not declared in this scope
> >      for (const auto &codec : qAsConst(codecMap)) {
> >                                                ^
> > ui/qt/CMakeFiles/qtui.dir/build.make:1015: recipe for target
> > 'ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o' failed
> > make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error
> > 1
> > make[2]: *** Waiting for unfinished jobs....
> >
> > My installed version of Qt appears to be 5.6.2.
> >
> > Looking at CMakeLists.txt, there are various checks for Qt5Widgets, but
> > the earliest supported version looks like 5.3?
> >
> > I think  https://doc.qt.io/qt-5/qtglobal.html#qAsConst  was introduced
> > in 5.7.
> > Do we want to bump the minimum versions?
> >
> > Martin

-- 
Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe