Re: Problem in 'packet-f5ethtrailer.c'

["Maynard, Chris via Wireshark-dev" <wireshark-dev () wireshark org>]

> -----Original Message-----
> From: Wireshark-dev <wireshark-dev-bounces () wireshark org> On Behalf
> Of Gisle Vanem
> Sent: Thursday, March 19, 2020 10:41 AM
> To: wireshark-dev <wireshark-dev () wireshark org>
> Subject: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'
>
> I'm surprised no one has come across this compile error yet:
>    epan/dissectors/packet-f5ethtrailer.c(482): error C2143: syntax error:
> missing ';' before '.'
>    epan/dissectors/packet-f5ethtrailer.c(485): error C2224: left of '.S_addr'
> must have struct/union type
>    epan/dissectors/packet-f5ethtrailer.c(487): error C2224: left of '.S_addr'
> must have struct/union type
>
> (using MSVC-2019).
>
> Reason seems simple; <winsock2.h> has snuck in somehow and added the
> wellknown "#define s_addr S_un.S_addr"
>
> A simple fix is:
>
> --- a/epan/dissectors/packet-f5ethtrailer.c 2020-03-19 13:31:36
> +++ b/epan/dissectors/packet-f5ethtrailer.c 2020-03-19 14:26:51
> @@ -204,6 +204,7 @@
>   #include <epan/stats_tree.h>
>   #define F5FILEINFOTAP_SRC
>   #include "packet-f5ethtrailer.h"
> +#undef s_addr
>   #undef F5FILEINFOTAP_SRC

Which specific release of VS2019 are you running?  This is a bit of a stretch, but *possibly* your version could use an 
update?

As an added data point, I updated to 16.5 this week and I just recompiled Wireshark sources without any problem.
It seems the buildbots are running 16.0, so if you're running a version in between the two and one of those versions 
introduced this change, then *maybe* that could explain it?

Well, if that's not the problem, then there would appear to be something else different/unique to your build 
environment causing this.  I suppose we'd need more info ...
- Chris
https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes












CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and 
may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the 
addressee. If you are not the intended recipient and have received this message in error, please delete this message 
from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is 
strictly prohibited.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe