Windows builds: Spectre-mitigated libraries

["Maynard, Chris via Wireshark-dev" <wireshark-dev () wireshark org>]

I noticed in the CMakeError.log file the following:

      C:\Program Files (x86)\Microsoft Visual 
Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(458,5): error MSB8040: Spectre-mitigated 
libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for 
any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c

I installed the Spectre-mitigated libraries and this error message no longer appears.  CMake also now reports:

      Performing C SOURCE FILE Test C_Qspectre_VALID succeeded
      Performing C++ SOURCE FILE Test CXX_Qspectre_VALID succeeded

However, it seems the Windows buildbots[1][2][3] do not have these Spectre-mitigated libraries installed, because in 
the most recent CMake stdio output from the two Windows master builders, Windows Server 2019 x64 and Windows Server 
2019 x86, I see:

      -- Performing Test C_Qspectre_VALID
      -- Performing Test C_Qspectre_VALID - Failed
      -- Performing Test CXX_Qspectre_VALID
      -- Performing Test CXX_Qspectre_VALID - Failed

Should the Spectre-mitigated libraries be installed on all Windows buildbots, and should the Wireshark Developer's 
Guide[4] be updated to inform developers to also install them?
- Chris
[1]: https://buildbot.wireshark.org/wireshark-master/waterfall
[2]: https://buildbot.wireshark.org/wireshark-3.4/waterfall
[3]: https://buildbot.wireshark.org/wireshark-3.2/waterfall
[3]: https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html#ChSetupMSVC











CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and 
may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the 
addressee. If you are not the intended recipient and have received this message in error, please delete this message 
from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is 
strictly prohibited.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe