Re: Do we see false positives on the prechecks in merge-request runners

[Richard Sharpe <realrichardsharpe () gmail com>]

On Mon, Feb 1, 2021 at 7:22 AM Pascal Quantin <pascal () wireshark org> wrote:
> Hi Richard,
>
> Le lun. 1 févr. 2021 à 16:09, Richard Sharpe <realrichardsharpe () gmail com> a écrit :
> > Hi folks,
> >
> > In one of the builds for my merge request around Robust AV Streaming,
> > I got this:
> >
> > https://gitlab.com/wireshark/wireshark/-/jobs/998246552
> >
> > It is complaining that an ENC_BIG_ENDIAN should be ENC_NA, but in
> > looking at the code, it already is ENC_NA and I have not changed that
> > for a while (but perhaps the original code was wrong.)
>
>
> This is not a false positive: your MR https://gitlab.com/wireshark/wireshark/-/merge_requests/1885 is adding those 
> two new fields hf_ieee80211_tclas4_ipv6_src and hf_ieee80211_tclas4_ipv6_dst and they use ENC_BIG_ENDIAN instead of 
> ENC_NA.

Whoa. When I do a git show I see that the patch shows ENC_BIG_ENDIAN.

However, when I look at the code, even after I have added and done a
git commit --amend, it shows ENC_NA.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe