Re: Parameters for extcap

[Roland Knall <rknall () gmail com>]

Both issues where done so by design.

For the password, there was a reasonable concern, that passwords may be
read-out. Now, you could argue, that monitoring the cumpcap call gives you
the password anyway, which is correct. The intended usecase originally was
to use the password together with ssh, which was later superseded by using
the identity file, which can be stored normally.

As for empty values, we have no possibility to detect, if the empty value
you entered is the default one, or if it is a new set value. Therefore
empty was implemented as "return default value". One could argue, that
default values should only be used, if you reset the complete
configuration, but than you could not reset an individual configuration.

regards
Roland


Am Di., 30. Nov. 2021 um 00:54 Uhr schrieb Jirka Novak <j.novak () netsystem cz
> :

> Hi,
>
>   Wireshark is able to run external captures (extcap). Extcap tools can
> provide configuration description which Wireshark shows as dialog and
> stores in advanced properties.
>   I'm observing two strange things I understood as bug.
>
> 1) If the tools provides as type of setting 'password', it is not stored
> permanently. It is correct.
> The issue is, that password is not remembered over runtime. So if I run
> extcap twice in row, second run has empty password :-(
> I think it is related to #14221, but I think that it should remember
> password till application is closed.
>
> 2) If the tool provides default value for a setting, it is stored in
> preference. If I change the value, it is stored too. It is correct.
> The issue is, that if I clear the value to do not pass the value to
> extcap (it is not required), the empty value is not stored so next run
> default value is again used.
>
> Both issues are very annoying.
>
> My plan is to change it:
> - remember password during runtime
> - store empty values
>
> My worry is about storing empty values to preferences. I'm afraid that
> the framework uses empty value to remove settings from preference.
>
> Can I ask for comments and advices before I will proceed?
>
>                                         Best regards,
>
>                                                 Jirka Novak
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe