Re: [PATCHed] Using dnet headers for TCP and UDP

[Kris Katterjohn <katterjohn () gmail com>]

Kris Katterjohn wrote:
> ------------------------------------------------------------------------
> r4379 | kris | 2007-01-22 23:29:59 -0600 (Mon, 22 Jan 2007) | 1 line
>
> Use dnet headers for TCP and UDP. This allows us to remove netinet tcp.h
> and udp.h references, the udphdr_bsd stuff, and the TH_ECE/TH_CWR
> #defines in tcpip.h. That was easy, but we (Fyodor and I) came to the
> conclusion that IP and ICMP aren't worth the hassle to switch (I was
> testing TCP, UDP and IP in my branch). The struct icmp_hdr in dnet isn't
> setup anything like what we're using now. Then, struct ip_hdr uses
> ip_addr_t (typedef'd to uint32_t in that ip.h) instead of struct in_addr
> for the IP addresses, and that would require some dnet modifying to work
> right. We might be able to come up with some elegant solution for IP,
> but probably not for ICMP. For now, they're still left up to netinet (or
> tcpip.h).
> ------------------------------------------------------------------------

Okay, I've committed a patch to further clean up. The SVN log:

------------------------------------------------------------------------
r4445 | kris | 2007-01-31 17:37:18 -0600 (Wed, 31 Jan 2007) | 1 line

Removing mswin32/netinet/tcp* and udp*. Thanks to my dnet header patch
(r4379), we're able to safely remove all of these files and then remove
their references from mswin32/winclude.h. tcp_var.h wasn't used
anywhere, and all of the others are only used in libpcap/. Since these
NETINET files are only used for Windows, and WinPcap is required for
that, this isn't a problem. I've tested it on Windows XP with MS VC++
Express 2005.
------------------------------------------------------------------------

If you have any problems with this, please let me know.

Thanks,
Kris Katterjohn

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org