Re: [NSE] Local IP geolocation script

[Fyodor <fyodor () insecure org>]

On Tue, Nov 18, 2008 at 09:23:35PM +0100, Philipp Emanuel Weidmann wrote:
> I fully support a standardized naming convention for script files. 
> However, e.g. with the script "netbios-smb-os-discovery.nse" in a 
> standard terminal window the script name is more than half the output 
> line which IMO is serious overkill.

Well, the script is actually named "smb-os-discovery.nse", and the output looks like:

Host script results:
Host script results:
|  smb-os-discovery: Unix
|  LAN Manager: Samba 3.0.31-0.fc8
|  Name: WORKGROUP\
|_ System time: 2008-11-18 13:12:21 UTC-8

So the "| smb-os-discovery: " prefix takes 21 characters, which is
about 1/4 the width of an 80-character-wide terminal window.  Also, we
could consider removing one of the spaces from each line.  My first
impression is that this looks just as good:

Host script results:
| smb-os-discovery: Unix
| LAN Manager: Samba 3.0.31-0.fc8
| Name: WORKGROUP\
|_System time: 2008-11-18 13:12:21 UTC-8

I'm not sure why there is a backslash after WORKGROUP.

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org