Re: Last FreeBSD Ports Patch for a bit

[Daniel Roethlisberger <daniel () roe ch>]

Might be a good moment to jump into this discussion, since I
maintain the Nmap related FreeBSD ports.

Jay Fink <jay.fink () gmail com> 2009-09-25:
> > Thanks Jay.  Does FreeBSD before 5.0 lack va_copy(), or is there some
> > other reason this is done?  Maybe what we should really do is test for
> > va_copy in configure (and leave it undefined on Windows) and then
> > change this section into a HAVE_VA_COPY define test.
>
> Sweet catch.
>
> Yes va_copy is in freebsd-current (and probably at least version 7,
> I'll look into it some more tonite).
>
> Your solution is better but now that I think of it I'm not sure
> it is worth it; or this patch in particular; - I don't think
> being 2-3 revs backward compatible for freebsd is an issue
> really.

The reason I haven't merged these particular port patches back to
the upstream Nmap repository is that they are non-generic hacks
to make Nmap build on oldish releases of FreeBSD.  As Fyodor has
suggested, the clean solution I think would be to test for
required features in configure and use the resulting defines to
decide which code to use.

Jay, if you are looking for more patch juggling tasks, you could
try to sort through our local modifications in libdnet-stripped
to merge them to upstream libdnet.  Contact me off-list for
details if you're interested.

-- 
Daniel Roethlisberger
http://daniel.roe.ch/

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org