Nmap Development mailing list archives
Re: Add XML support to NSE
From: Duarte Silva <duartejcsilva () gmail com>
Date: Tue, 29 Sep 2009 11:51:00 +0100
Hi Patrick, On 9/29/09, Patrick Donnelly <batrick () batbytes com> wrote:
Hi Duarte, On Mon, Sep 28, 2009 at 5:28 PM, Duarte Silva <duartejcsilva () gmail com> wrote:Hi, The following set of patches add XML support to NSE by using Expat. To make the code review easier I have broken the changes in three separated files. nse-xml-libexpat.patch - Add all the Expat source/header library files and the Visual Studio solution file nse-xml-solchanges.patch - Changes to Visual Studio nmap.sln and nmap.vcproj files nse-xml-support.patch - Files that make the bridge between NSE and ExpatGenerally we only add libraries when a script part of the trunk makes use of that library. You will need to also give us a viable script before we consider using this library addition.
I didn't add a viable script because that didn't seem to be a requirement and since this was in the TODO list. o [NSE] BasicHTML/XML parser? For example, Sven Klemm wrote a script which uses libxml2: http://seclists.org/nmap-dev/2008/q3/0462.html
Also, it appears this patch (#3) is a modified version of a Lua 4.0 Expat Binding [1]. I cannot find the updated version to Lua 5.1 (if your patch is an updated version to 5.1). You must cite where you found your code, what its license is, and whether you modified their code (and why).
No sorry it isn't, didn't even know that web page.
Also, why is this binding better than Kepler's Expat binding [2]?
It isn't better. It's based in the NSE pcre and nsock library and when I didn't know of a good way to handle the callbacks I found the Kepler's binding which passed the callbacks as a parameter in the constructor. I did the changes and added a few functions that were missing based on that code. I didn't add the license because it's the same as LUA.
[1] http://www.place.org/~nop/lua/ [2] http://www.keplerproject.org/luaexpat/ Thanks, -- -Patrick Donnelly "Let all men know thee, but no man know thee thoroughly: Men freely ford that see the shallows." - Benjamin Franklin _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- Add XML support to NSE Duarte Silva (Sep 28)
- Re: Add XML support to NSE Patrick Donnelly (Sep 28)
- Re: Add XML support to NSE Duarte Silva (Sep 29)
- Re: Add XML support to NSE Ron (Sep 29)
- Re: Add XML support to NSE Patrick Donnelly (Sep 29)
- Message not available
- Re: Add XML support to NSE Duarte Silva (Sep 29)
- Re: Add XML support to NSE Patrick Donnelly (Sep 28)
- Message not available
- Re: Add XML support to NSE Duarte Silva (Sep 29)