Cleaning the Win build

[Gisle Vanem <gvanem () broadpark no>]

I'm starting a new thread on this, since we strayed away from the
original thread...

"Luis MartinGarcia." <luis.mgarc () gmail com> wrote:

> When I've tested Nping on Windows, I've been able to compile it just
> fine, using Visual Studio (the "recommended" way to build on Windows),

The VC-Express 2008 is deprecated, so I've read. So I decided to try with 
VC-Express 2010. There were problems compiling the winfix.cc files. I shall 
not go into details, but I suspect the root of the problem is that local-headers
are ahead of system/SDK-headers. Have you tried to do a complete rebuild with 
VC-2010 lately?

> but I do understand people that prefer to use MingW. Obviously, we can
> make a few changes to improve our support for MingW. Since you have been
> looking into the problem, could you please produce a patch that fixes
> the issue and/or improves the existing header organization?

First we need to lay down some ground-rules for the Win-build. I suggest:

1. No local-headers should include other local-headers more than one level deep.

2. No local-headers should need to redefine things or define things twice (e.g.
  *win.h files with '#define HAVE_OPENSSL' in 4 places).

3. All system-headers should be included ahead of local ones. 

4. There should be only one (hand-edited) config-file in the whole Nmap-src tree.
 I suggest we name this mswin/config.h.

5. Do we need for 2 winfix.cc files? Except for the option-stuff (NmapOps/NpingOps),
 could these be merged and put into libnetutil/?

If we can do at least 1-4 in small steps, I would be happy. Comments anyone?

--gv

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/