Re: Peter's status report - #12 of 17

[Peter O <perdo.olma () gmail com>]

On Sat, Jul 21, 2012 at 2:33 AM, jah <jah () zadkiel plus com> wrote:
> On 20/07/2012 20:46, Rob Nicholls wrote:
> > > -----Original Message-----
> > > From: nmap-dev-bounces () insecure org [mailto:nmap-dev-
> > > bounces () insecure org] On Behalf Of Peter O
> > > Sent: 20 July 2012 12:21
> > > To: jah () zadkiel plus com
> > > Cc: nmap-dev
> > > Subject: Re: Peter's status report - #12 of 17
> > > Hi jah,
> > >
> > > thanks for reporting those issues. I've committed the changes in r29280.
> >
> > I just tried compiling from SVN on Windows and it failed with a load of
> > errors due to problems with nse_fs.cc. I've not looked into it in too much
> > detail, but there's presumably some problem related to the includes, or
> > order of the includes? I tried to make the file look more like what jah
> > suggested in his original email, and now it seems to compile okay on
> > Windows
> > in Visual Studio. I'd appreciate if someone takes a much closer look at
> > this, rather than committing the attached patch myself.
> >
> > Rob
>
>
> I see this too and I think you're right about the includes and their new
> order.  Your patch works for me; I've attached another which also removes
> the unnamed enum (as Paul had done in r29280) and removes the extraneous
> includes (all but sys/utime.h and direct.h). I think you should commit it if
> you're happy to do so.

Thanks for the patch jah. Committed as r29289.
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/