Re: [Patch] nsock/tests/tests_main.c

[Henri Doreau <henri.doreau () gmail com>]

2013/8/11 Gisle Vanem <gvanem () broadpark no>:
> "Henri Doreau" <henri.doreau () gmail com> wrote:
>
> > > No it wasn't that. Simply that WSAStartup() wasn't called. That could
> > > go into a local win_init() that sets up the WinConsole.
> > Could you send it as a patch?
>
>
> Attached. Also, ncat/test/addrset.c suffers the same problem.
> Also attached.
Why do they both initialize winsock with different version numbers?

Does the simple patch attached sound good to you? I've stripped down
the ANSI colors part. On trunk I simply print results without anything
fancy when running on windows. They're not important and I'd like to
keep it very simple. I'd actually rather use no colors at all than
have complex platform-specific initialization code just for that.

> > I know, and it's a pity because these designated initializers are so
> > nice... But can the nsock test suite be compiled using MSVC? There's
> > no project file nor anything.
>
>
> I've made a project + makefile for it. But this .sln-file will have to
> wait.
It'd be nice!

> > +/* socket_strerror() comes from nbase
> > + * Declared here to work around a silly inclusion issue until I can fix
> > it. */
> > +char *socket_strerror(int errnum);
>
>
> What's problem including <nbase.h> in "test-common.h"?
>
> --gv
I get double declaration errors which I need to investigate, it's
probably nothing big. I find it ugly as hell but had no time to clean
it since I noticed.

Regards

-- 
Henri

Attachment: nsock_test_win_init.patch
Description:

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/