Re: Regarding pull requests on Github

[Daniel Miller <bonsaiviking () gmail com>]

Kevin,

Thanks for reminding the list of this. Traditionally, code patches and new
scripts were sent to this mailing list, where our team of committers could
comment and merge them. Moving to Github has made contributing patches
easier and has given us more code quality and review tools, but I think
some of the visibility is lost because of our split SVN/git system [1].
Ideally, we will move entirely to Github and allow our trusted committers
to have access there to review and accept pull requests directly. Until
then, though, the PR review process is a little rusty. Please bear with us!

If there is a particular PR that you are concerned with, bringing it up
here on the nmap-dev list would be a good way to get some additional
attention and maybe some feedback from devs who are not yet on Github.

Dan

[1] https://github.com/nmap/nmap/blob/master/CONTRIBUTING.md

On Tue, Jan 10, 2017 at 10:19 PM, Kevin Lasrado <crypticclue88 () gmail com>
wrote:

> Hey,
> Can someone review the pull requests made on GitHub. Most of them have
> been there for quite a while.
>
>
> _______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/