Re: Regarding pull requests on Github

[Phil Young <mainframed767 () gmail com>]

That sounds awesome. I'm not often going to github to see pull requests,
though I could setup my own notifications,  seeing them here and other
people's comments would be interesting.

Thank you.

On Wed, Jan 11, 2017, 2:25 PM Daniel Miller <bonsaiviking () gmail com> wrote:

> Phil,
>
> That's a good idea, and I've looked into it before. It comes down to this:
> we have to write a web hook handler that accepts HTTP POST messages from
> Github, verifies an HMAC, and then sends an email to the list. I really
> wish they made this easier, but the Notifications settings don't allow the
> use of an email we can't send from (dev () nmap org) nor filtering just for
> pull requests. I'm investigating this again, and I think we'll try a
> solution based around python-github-webhooks [1], since it deploys as WSGI
> (which we already have on Nmap.org) has minimal dependencies, and does the
> HMAC verification. The longer-term solution is migrating more completely to
> Github and getting our committers involved there.
>
> Dan
>
> [1] https://github.com/carlos-jenkins/python-github-webhooks
>
> On Wed, Jan 11, 2017 at 12:00 PM, Phil Young <mainframed767 () gmail com>
> wrote:
>
> Would it be possible to have the pull requests emails sent to this mailing
> list or would that cause too much spam?
>
> On Wed, Jan 11, 2017 at 9:58 AM, Daniel Miller <bonsaiviking () gmail com>
> wrote:
>
> Kevin,
>
> Thanks for reminding the list of this. Traditionally, code patches and new
> scripts were sent to this mailing list, where our team of committers could
> comment and merge them. Moving to Github has made contributing patches
> easier and has given us more code quality and review tools, but I think
> some of the visibility is lost because of our split SVN/git system [1].
> Ideally, we will move entirely to Github and allow our trusted committers
> to have access there to review and accept pull requests directly. Until
> then, though, the PR review process is a little rusty. Please bear with us!
>
> If there is a particular PR that you are concerned with, bringing it up
> here on the nmap-dev list would be a good way to get some additional
> attention and maybe some feedback from devs who are not yet on Github.
>
> Dan
>
> [1] https://github.com/nmap/nmap/blob/master/CONTRIBUTING.md
>
> On Tue, Jan 10, 2017 at 10:19 PM, Kevin Lasrado <crypticclue88 () gmail com>
> wrote:
>
> Hey,
> Can someone review the pull requests made on GitHub. Most of them have
> been there for quite a while.
>
>
> _______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
>
>
>
> _______________________________________________
> Sent through the dev mailing list
> https://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
>
>
>
>
> --
> Soldier of Fortran
> @mainframed767
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/