Re: buildbot failure in Wireshark (development) on Ubuntu-10.04-x64

[Jeff Morriss <jeff.morriss.ws () gmail com>]

Bill Meier wrote:
> buildbot-no-reply () wireshark org wrote:
> > The Buildbot has detected a new failure of Ubuntu-10.04-x64 on Wireshark (development).
> > Full details are available at:
> >  http://buildbot.wireshark.org/trunk/builders/Ubuntu-10.04-x64/builds/646
> >
> > Buildbot URL: http://buildbot.wireshark.org/trunk/
> >
> > Buildslave for this Build: ubuntu-10.04-x64
> >
> > Build Reason: 
> > Build Source Stamp: 34581
> > Blamelist: morriss,wmeier
> >
> > BUILD FAILED: failed fuzz-menagerie
> >
> > sincerely,
> >  -The Buildbot
>
> I'm looking at this ....
>
> Capinfos getting an error when reading a file;
>
> Some issue with wiretap ipfix add doe recently ??

I started looking this morning too.  The attached patch fixes the crash, 
but there's more work to do: 1.4 correctly detects the file type.

(I'll stop looking now to avoid further duplicating effort.)

Index: wiretap/ipfix.c
===================================================================
--- wiretap/ipfix.c     (revision 34585)
+++ wiretap/ipfix.c     (working copy)
@@ -139,6 +139,7 @@
     if (pfx_hdr->version != IPFIX_VERSION) {
         /* Not an ipfix file. */
         *err = WTAP_ERR_BAD_RECORD;
+        *err_info = g_strdup_printf("ipfix: wrong version %d", pfx_hdr->version);
         return FALSE;
     }
 
@@ -188,8 +189,8 @@
     for (i = 0; i < records_for_ipfix_check; i++) {
         /* read first message header to check version */
         if (!ipfix_read_message_header(&msg_hdr, wth->fh, err, err_info)) {
-            ipfix_debug2("ipfix_open: couldn't read message header #%d with err code #%d",
-                         i, *err);
+            ipfix_debug3("ipfix_open: couldn't read message header #%d with err code #%d (%s)",
+                         i, *err, *err_info);
             if (*err == WTAP_ERR_BAD_RECORD) return 0;
             if (*err != 0) return -1; /* real failure */
             /* else it's EOF */

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe