Wireshark mailing list archives
Re: Simplifying (and fixing) tvbuff [Long]
From: Bill Meier <wmeier () newsguy com>
Date: Wed, 21 Dec 2011 19:11:38 -0500
On 12/21/2011 12:40 PM, Bill Meier wrote:
ToDo: - Update epan/tvbtest.c - Test composite tvbs (They might now even work).
Done ... I've updated tvbtest.c slightly to reflect the recent tvbuff.c revisions.I've also fixed an issue in tvbtest.c which caused some of the composite tvb tests to fail.
All of the tests in tvbtest now run successfully (including those testing composite tvbs).
So there's some claim that composite tvbs now work. I'd want to do a detailed walkthrough of the tvbuff composite code with a debugger before I'd be comfortable with actually using composite tvbs.
Whether using composite tvbs as currently implemented is a good thing is, of course, a different discussion.
Bill ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Simplifying (and fixing) tvbuff [Long] Bill Meier (Dec 12)
- Re: Simplifying (and fixing) tvbuff [Long] Bill Meier (Dec 12)
- Re: Simplifying (and fixing) tvbuff [Long] Bill Meier (Dec 13)
- Re: Simplifying (and fixing) tvbuff [Long] Chris Maynard (Dec 14)
- Re: Simplifying (and fixing) tvbuff [Long] Jaap Keuter (Dec 14)
- Re: Simplifying (and fixing) tvbuff [Long] Chris Maynard (Dec 14)
- Re: Simplifying (and fixing) tvbuff [Long] Bill Meier (Dec 21)
- Re: Simplifying (and fixing) tvbuff [Long] Bill Meier (Dec 21)
- Re: Simplifying (and fixing) tvbuff [Long] Jaap Keuter (Dec 24)
- Re: Simplifying (and fixing) tvbuff [Long] Bill Meier (Dec 21)