Re: FW: [Wireshark-commits] rev 46479: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-per.c

[Martin Mathieson <martin.r.mathieson () googlemail com>]

Maybe.  I'm guessing we'd probably want to improve decode_bits_in_field()
to avoid those g_strlcat() calls by keeping track of the offset.
Martin

On Sun, Dec 9, 2012 at 11:07 AM, Anders Broman
<anders.broman () ericsson com>wrote:

> Hi,
> Would using proto_tree_add_bits_item() be less efficient? Possibly that
> can be improved which would give
> A better over all improvement I think.
> Regards
> Anders
>
> -----Original Message-----
> From: wireshark-commits-bounces () wireshark org [mailto:
> wireshark-commits-bounces () wireshark org] On Behalf Of
> martinm () wireshark org
> Sent: den 9 december 2012 05:50
> To: wireshark-commits () wireshark org
> Subject: [Wireshark-commits] rev 46479: /trunk/epan/dissectors/
> /trunk/epan/dissectors/: packet-per.c
>
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46479
>
> User: martinm
> Date: 2012/12/08 08:49 PM
>
> Log:
>  Similarly avoiding calling g_snprintf() in
> dissect_per_constrained_integer().
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path            Action
>   +7 -1      packet-per.c    Modified
>
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <
> wireshark-commits () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request () wireshark org
> ?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe