Wireshark mailing list archives

Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t)

From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Thu, 29 Nov 2012 15:27:22 -0500

Anders Broman wrote:

Hi,
Any one up for the task? :-)
I recently ran in to a crash caused by a proprietary plug-in with theabove error.
Packet-amr.c could be used for test.
A check in prefs_dlg.c wouldn't hurt either...

checkAPIs change done in r46294 (along with, as I'm sure you saw, acheck to ensure they're all const).


I'd shy away from a run-time check just to save (startup) cycles.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread:

Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Anders Broman (Nov 28)
- Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Jeff Morriss (Nov 29)
  - Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Anders Broman (Nov 30)