Wireshark mailing list archives
Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t)
From: Anders Broman <anders.broman () ericsson com>
Date: Fri, 30 Nov 2012 11:35:22 +0000
Thanks a million Jeff. -----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Jeff Morriss Sent: den 29 november 2012 21:27 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Anders Broman wrote:
Hi, Any one up for the task? :-) I recently ran in to a crash caused by a proprietary plug-in with the above error. Packet-amr.c could be used for test. A check in prefs_dlg.c wouldn't hurt either...
checkAPIs change done in r46294 (along with, as I'm sure you saw, a check to ensure they're all const). I'd shy away from a run-time check just to save (startup) cycles. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Anders Broman (Nov 28)
- Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Jeff Morriss (Nov 29)
- Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Anders Broman (Nov 30)
- Re: Enhance checkapi to check for non NULL terminated enum preferenses (enum_val_t) Jeff Morriss (Nov 29)