Re: dissect_sip_tcp_heur()

[Pascal Quantin <pascal.quantin () gmail com>]

2013/8/10 Martin Kaiser <lists () kaiser cx>

> I came across this while browsing through the coverity defects.
>
> gboolean first = TRUE; is never changed
>
> Does the following change make sense to those who are familiar with SIP?
>
> diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c
> index fa317c8..c04a0c8 100644
> --- a/epan/dissectors/packet-sip.c
> +++ b/epan/dissectors/packet-sip.c
> @@ -2104,6 +2104,7 @@ dissect_sip_tcp_heur(tvbuff_t *tvb, packet_info
> *pinfo, proto_tree *tree, void *
>                 if (len == -1)
>                         break;  /* need more data */
>                 offset += len;
> +               first = FALSE;
>         }
>         return TRUE;


Hi Martin,
I'm not really familiar with SIP over TCP (in all my use cases, SIP is over
UDP) but your proposal makes sense.

Best regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe