Re: dissect_sip_tcp_heur()

[Hadriel Kaplan <hadriel.kaplan () oracle com>]

On Aug 12, 2013, at 6:22 AM, Martin Kaiser <lists () kaiser cx> wrote:

> > I'm not really familiar with SIP over TCP (in all my use cases, SIP is
> > over UDP) but your proposal makes sense.
>
> Thanks Pascal,
>
> that explains why nobody spotted this so far.

I think it's more because it's only the heuristic SIP/TCP dissector, instead of the normal SIP/TCP dissector. (Or at 
least I've never noticed a problem dissecting SIP/TCP, which I do on occasion.)

But yeah your fix looks right.

-hadriel

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe