Wireshark mailing list archives
Re: [Wireshark-commits] rev 50967: /trunk/epan/ /trunk/epan/: proto.c
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Mon, 29 Jul 2013 19:26:59 +0200
Hi, On Sun, Jul 28, 2013 at 08:33:49AM -0400, Evan Huus wrote:
I was poking through this change and I noticed that all three places that call proto_unregister_field (which is very inefficient at the moment, possibly traversing the entire linked list twice) do so in a loop for all their hfs,
AFAIK they're doing proto_unregister_field() on user-defined fields, so just a continuous subset.
so I was wondering if it makes sense to replace it with a proto_unregister_all_fields that just removes the whole list? I'm not sure if we want to leave proto_unregister_field around or not in case somebody actually needs it in the future - the data structures aren't really designed for that operation.
Just to note: I still plan to commit patch from: http://www.wireshark.org/lists/wireshark-dev/201307/msg00039.html saving 2 MB is nice (even if it's small fraction...) Cheers, Jakub. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 50967: /trunk/epan/ /trunk/epan/: proto.c Evan Huus (Jul 28)
- Re: [Wireshark-commits] rev 50967: /trunk/epan/ /trunk/epan/: proto.c Jakub Zawadzki (Jul 29)