Re: Wmem has reached feature-parity with emem

[Evan Huus <eapache () gmail com>]

On Wed, Jun 19, 2013 at 7:50 AM, Michal Labedzki
<michal.labedzki () tieto com> wrote:
> Hi,
> I have a problem. For example packet-btavctp.c, I created emem tree in
> proto_register_btavctp(). And it is ok. But after switch to wmem Wireshark
> fails (cannot run) with:
> "ERROR:wmem_scopes.c:96:wmem_file_scope: assertion failed: (in_file_scope)"
>
> This is my change:
> - reassembling = se_tree_create(EMEM_TREE_TYPE_RED_BLACK, "btavctp
> reassembling");
> + reassembling = wmem_tree_new(wmem_file_scope());
>
> Or maybe should I do that in register_init_routine() now? (I do not try)
>
> By the way: switch from emem tree to wmem tree seems to be only done by
> replace all "emem_tree" and "se_tree" by "wmem_tree", expect function create
> tree, right?

Unfortunately it is not quite so simple. I will write some doc and
perhaps create a helper function later today once I figure out the
exact changes needed. The difficulty is only on creation though, once
the tree exists all the inserts and lookups should just be replacable
automatically.

> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe