Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp

[Jakub Zawadzki <darkjames-ws () darkjames pl>]

On Thu, Nov 21, 2013 at 08:46:06AM -0500, Evan Huus wrote:
> I don't see any specific reason to keep the proto_ variables private,
> so I have no objection to making them available. All of the protocols
> involved in this case already have separate header files anyways.

I'd rather use proto_get_id_by_filter_name() in some init function, and later compare.

Making variables extern is somehow tempting, like we could extern dissector handles and stop using find_dissector() ;]
But I think it's wrong way.

Kuba.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe