Wireshark mailing list archives
Re: [Wireshark-commits] rev 51407: / /trunk/tools/: convert-proto-tree-new.awk
From: Joerg Mayer <jmayer () loplof de>
Date: Mon, 9 Sep 2013 18:26:34 +0200
On Mon, Sep 09, 2013 at 05:45:09PM +0200, Joerg Mayer wrote:
I just wanted to get familiar with the new hf_ stuff and tried the script on the doc/packet-PROTOABBREV.c and I got at least one thing that doesn't look right: The code of the converted file contains "THIS_HF_INIT =", which should probably be "HFI_PROTOABBREV ="? The #define gets added at the very beginning of the file instead of after the initial comment(s) section. Are there any other things that are incorrect / not good?
- it seems to lack something simialar to: "#define DAYTIME_HFI_INIT HFI_INIT(proto_daytime)" - "static &hfi_register_info hf[] = {" doesn't look good either ciao Jörg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 51407: / /trunk/tools/: convert-proto-tree-new.awk Joerg Mayer (Sep 09)
- Re: [Wireshark-commits] rev 51407: / /trunk/tools/: convert-proto-tree-new.awk Joerg Mayer (Sep 09)