Re: [Wireshark-commits] rev 51407: / /trunk/tools/: convert-proto-tree-new.awk

[Joerg Mayer <jmayer () loplof de>]

Jakub,

On Sat, Aug 17, 2013 at 07:35:01PM +0000, darkjames () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51407
>
> User: darkjames
> Date: 2013/08/17 12:35 PM
>
> Log:
>  Commit far from being perfect conversation tool from hfindex to hfinfo.
>
> Directory: /trunk/tools/
>   Changes    Path                          Action
>   +89 -0     convert-proto-tree-new.awk    Added

I just wanted to get familiar with the new hf_ stuff and tried the script on the
doc/packet-PROTOABBREV.c and I got at least one thing that doesn't look right:
The code of the converted file contains "THIS_HF_INIT =", which should probably
be "HFI_PROTOABBREV ="?
The #define gets added at the very beginning of the file instead of after the
initial comment(s) section.
Are there any other things that are incorrect / not good?

Thanks
    Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe