Re: LTE-RRC doesn't compile cleanly in master-1.10

[Pascal Quantin <pascal.quantin () gmail com>]

2014-04-11 6:57 GMT+02:00 Pascal Quantin <pascal.quantin () gmail com>:

> Le 11 avr. 2014 05:07, "Evan Huus" <eapache () gmail com> a écrit :
>
> > Ya, it's usable in 1.10 though it's not as efficient or featureful. It
> couldn't fully replace emem at that point, but for one-off use
> (backporting?) it should work just fine.
> > Switching it back to emem would also probably work with no ill-effects.
> Whatever's easier.
> > Evan
> >
> > > On Apr 10, 2014, at 10:02 PM, Jeff Morriss <jeff.morriss.ws () gmail com>
> wrote:
> > > The warning-turned-error (I like to compile the branches with
> warnings-as-errors to catch this kind of thing) is:
> > > >  CC       libdissectors_la-packet-lte-rrc.lo
> > > > ../../asn1/lte-rrc/packet-lte-rrc-fn.c: In function
> 'dissect_lte_rrc_SystemInfoListGERAN_item':
> > > > ../../asn1/lte-rrc/packet-lte-rrc-fn.c:13442:9: error: implicit
> declaration of function 'wmem_alloc' [-Werror=implicit-function-declaration]
> > > > ../../asn1/lte-rrc/packet-lte-rrc-fn.c:13442:22: error: cast to
> pointer from integer of different size [-Werror=int-to-pointer-cast]
> > > > cc1: all warnings being treated as errors
> > > > make[5]: *** [libdissectors_la-packet-lte-rrc.lo] Error 1
> > >
> > > Normally I'd just add an include of wmem.h but is wmem ready for use
> in the 1.10 branch?  I thought not but maybe I'm mis-remembering.
>
> Hi all,
> I introduced this when backporting a fix and just checked it was compiling
> at the end without checking the warnings generated. Sorry about that. I
> will take care of it (probably today) if no one beats me.

Should be fixed in 71d7d57282c8bcc0970ac916f876970b24eaf667.

Regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe