Wireshark mailing list archives

Re: [Wireshark-commits] master fc5d8db: Create the HTTP tree after we're assured it's HTTP. Otherwise a bogus tree is created when HTTP2 traffic is found.


From: Evan Huus <eapache () gmail com>
Date: Tue, 22 Apr 2014 22:20:17 -0400

The DTLS decryption test has been failing for the last few days
because of this. Not sure what the relation is, but...

On Sun, Apr 20, 2014 at 8:40 AM, Wireshark code review
<code-review-do-not-reply () wireshark org> wrote:
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc5d8db74dc473610b9fc6c0c4b571d4aa65264a
Submitter: Michael Mann (mmann78 () netscape net)
Changed: branch: master
Repository: wireshark

Commits:

fc5d8db by Michael Mann (mmann78 () netscape net):

    Create the HTTP tree after we're assured it's HTTP.  Otherwise a bogus tree is created when HTTP2 traffic is 
found.

    Change-Id: Ic315ed9b7d65fe70401945cb0cceda4af863d140
    Reviewed-on: https://code.wireshark.org/review/1215
    Reviewed-by: Alexis La Goutte <alexis.lagoutte () gmail com>
    Reviewed-by: Michael Mann <mmann78 () netscape net>


Actions performed:

    from  d0489f2   Clean up white space (replace tabs with 4 spaces).
    adds  fc5d8db   Create the HTTP tree after we're assured it's HTTP.  Otherwise a bogus tree is created when HTTP2 
traffic is found.


Summary of changes:
 epan/dissectors/packet-http.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: