Wireshark mailing list archives
Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer.
From: Evan Huus <eapache () gmail com>
Date: Mon, 18 Aug 2014 15:46:38 -0400
Guy, how are you finding these last four or five API abuses? Do you have some sort of super-checkAPIs or are you just doing a lot of manual code review? On Mon, Aug 18, 2014 at 3:44 PM, Wireshark code review <code-review-do-not-reply () wireshark org> wrote:
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b7dd1efcef07dbdb69320e13832a4d7a087b9a8 Submitter: Guy Harris (guy () alum mit edu) Changed: branch: master Repository: wireshark Commits: 7b7dd1e by Guy Harris (guy () alum mit edu): Don't use -1 as the length of an integer. That's not supported. Put the unknown enterprise number in a a 4-byte value, as that's what it is, and then just skip to the end of the packet. Change-Id: I2cce84bfbb46a114d4809dbc61a021d497eb87a8 Reviewed-on: https://code.wireshark.org/review/3708 Reviewed-by: Guy Harris <guy () alum mit edu> Actions performed: from 9d6d192 Use expert info to report unknown TLV types. adds 7b7dd1e Don't use -1 as the length of an integer. Summary of changes: epan/dissectors/packet-sflow.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Evan Huus (Aug 18)
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Guy Harris (Aug 18)
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Evan Huus (Aug 18)
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Jeff Morriss (Aug 18)
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Evan Huus (Aug 18)
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Evan Huus (Aug 18)
- Re: [Wireshark-commits] master 7b7dd1e: Don't use -1 as the length of an integer. Guy Harris (Aug 18)