Re: Adding a new dissector - beginners guide

[Bill Meier <wmeier () newsguy com>]

On 8/22/2014 5:22 AM, Graham Bloice wrote:
> On 22 August 2014 10:18, Thomas Wiens <th.wiens () gmx de
> <mailto:th.wiens () gmx de>> wrote:
>
>
>     I've got another question to working on the comments in the review
>     system:
>
>     Is it good style to push every fixed comment as a single commit, or
>     should I work on all comments, and commit them together as once, with
>     multiple comments?
>
>     I've looked into older git comments in the review system, but did't
>     found a nice review process with commits, to look what style you prefer.
>
>
> IMHO, I'd prefer to see reviewer lead changes in one lump as diffing
> each patch set could be tedious.  I'm basically reviewing the final
> patch as will be merged to master.  Others may have a different view.
>
> --
> Graham Bloice


+1





___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe