Wireshark mailing list archives

Re: Adding a new dissector - beginners guide


From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Fri, 22 Aug 2014 10:11:15 -0400

On 08/22/14 09:51, Thomas Wiens wrote:
Hi,
I've just commited a fixed version.
I think I did something wrong. In the review system it is shown as a new
version.

I used:
git commit -a
git review

If you were on the same branch as your original commit (or if you re-downloaded your change with "git review -d") you probably should have done "git commit -a --amend" or otherwise ensured that the Change-ID in the commit message stayed the same.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: