Re: Gerrit patches with trailing whitespace

[Bill Meier <wmeier () newsguy com>]

On 8/25/2014 1:48 PM, Alexis La Goutte wrote:
> > > Should we add some info then to the Dev Guide as to where to get the hook,
> >
> > It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup
> >
> > We keep running into this problem - should the wiki page and the dev
> > guide be consolidated?
> >
> > > and also run a server-side hook to reject the push?
> >
> > +1 if we can figure out how to return a nice error message explanation
> > and not just "Your change was rejected by the remote server."
> -1
> or only trailing whitespace check for the moment... ;-)

I agree with Alexis.

The hook needs work, which I started to do, but then I guess I lost 
interest when the work got to be "bigger than a breadbox" and then 
didn't announce that I was no longer working on making changes to the
hook.



Bill


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe