Wireshark mailing list archives

Re: Gerrit patches with trailing whitespace


From: Graham Bloice <graham.bloice () trihedral com>
Date: Mon, 25 Aug 2014 20:06:13 +0100

On 25 August 2014 20:03, Joerg Mayer <jmayer () loplof de> wrote:

On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote:
When reviewing some submissions on Gerrit, I've noted a few with trailing
whitespace.  The git pre-commit hook always warns me of this, so how are
folks managing to do this?  Are they using clients that ignore the hook?

How about adding a test to our build systems:

 If we are part of a git repo and .git/hooks/pre-commit doesn't exist
 then print a message at the end of the build that in case of an intended
 submission the file should be installed first.


+1



-- 
Graham Bloice
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: