Wireshark mailing list archives
Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests
From: Martin Kaiser <lists () kaiser cx>
Date: Wed, 27 Aug 2014 23:26:31 +0200
Hi Sean, Thus wrote Stalley, Sean (sean.stalley () intel com):
I think we should discuss how to clean up the usb dissector. It seems like we are running into the "too many cooks in the kitchen" scenario.
So far, our changes co-existed nicely. Now's the first time they were in conflict ;-)
My primary goal has been to reuse as much of the USB dissector as possible for the MA USB dissector.
I've been trying to simplify/modularize dissect_usb_common() along the way, but if I'm just getting in the way let me know.
I appreciate your work, the USB dissector definitely needs more cleanup. As I said in the previous mail, I'd like to reduce the number of state variables and simplify the execution flow (there's too many conditions and branches). I'll upload some more changes tomorrow. Best regards, Martin ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Martin Kaiser (Aug 26)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Pascal Quantin (Aug 26)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Graham Bloice (Aug 26)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Alexis La Goutte (Aug 26)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Stalley, Sean (Aug 26)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Pascal Quantin (Aug 26)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Martin Kaiser (Aug 27)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Michal Labedzki (Aug 27)
- Re: [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests Alexis La Goutte (Aug 26)