Wireshark mailing list archives

Re: Git+gerrit status update - 2014-01-14


From: Gerald Combs <gerald () wireshark org>
Date: Tue, 25 Feb 2014 15:02:24 -0800

On 2/25/14 2:42 PM, Joerg Mayer wrote:
On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote:
It sets up so that "git review" does the correct push, as well as
setting the gerrit topic to the current branch name (if different from
"master") and a few other conveniences. So there's no particular
reason to set up git push. This lets admins differentiate between push
(which force-pushes to master for admin purposes) and review (which
goes to gerrit).

Ah, now I understand! So now that I have managed to get my first three
commits into review, how do I proceed on the command line?
The reason I need to ask is that intro-quick only explains the workflow
via web browser - which is something that I'm not intending to use.
If I understand things correctly I should be able to do the same thing
using "git review", or am I wrong here somehow?

You should be able to run something like

ssh code.wireshark.org gerrit review --submit --code-review +2 \
    <change-id>

although I haven't tried it myself.


I have the following in my .ssh/config, which lets me omit the username
and port:

Host code.wireshark.org
        User gerald
        Port 29418

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: